[ipxe-devel] [PATCH 2/3] ethernet: do not construct EUI-64 identifier for empty MAC

[Hannes Reinecke]

On 03/01/2018 01:44 PM, Michael Brown wrote:
> On 05/02/18 08:36, Hannes Reinecke wrote:
>> If the MAC address is empty we should not construct an EUI-64
>> identifier, but rather return an error.
> 
> An empty MAC address will cause other problems.  If the driver expects
> the possibility of an empty MAC address, it should be using
> eth_random_addr() to construct a locally-assigned address.
> 
> Which driver ended up providing an empty MAC address?
> 
igbvf.

And ixgbevf will probably have the same problem.

For both you are required to set the MAC address prior to usa via the

ip link set dev <eth> vf <num> mac <mac>

trick.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)