[ipxe-devel] [PATCH] [build] Remove nested 'my' declaration.

[Robin Smidsrød]

On 27.05.2016 21:05, Vinson Lee wrote:
> Fix build error with perl >= 5.23.2.
> 
> Can't redeclare "my" in "my" at ./util/parserom.pl line 160, near ", "
> 
> Fixes: 68d8a44469ecd ("[build] Rewrite parserom.pl to support multiple source files")
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  src/util/parserom.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/util/parserom.pl b/src/util/parserom.pl
> index 28df606..5a849a5 100755
> --- a/src/util/parserom.pl
> +++ b/src/util/parserom.pl
> @@ -157,7 +157,7 @@ sub process_isa_rom {
>  
>  # Output Makefile rules for the specified ROM declarations
>  sub print_make_rules {
> -    my ( $state, my $image, my $desc, my $vendor, my $device, my $dup ) = @_;
> +    my ( $state, $image, $desc, $vendor, $device, $dup ) = @_;
>      unless ( $state->{'is_header_printed'} ) {
>          print "# NIC\t\n";
>          print "# NIC\tfamily\t$state->{family}\n";
> 

Thanks for the patch. Looks good.

Michael: Can you merge to master?

-- Robin