[ipxe-devel] [PATCH 2/2] Sync VLAN irq operation with trunk irq opertaion.

Wissam Shoukair wissams at mellanox.com
Wed Mar 5 13:32:07 GMT 2014


That’s right.
This fix is valid only for devices which do not work with interrupts in PXE. And while the PXE is per device, it doesn’t matter if you overwrite the static structure.
If there is a patch that I missed, which one option rom can handle multiple cards, I'll be happy to know.

Thanks,
Wissam

-----Original Message-----
From: Michael Brown [mailto:mcb30 at ipxe.org] 
Sent: יום ד 05 מרץ 2014 15:21
To: Wissam Shoukair; ipxe-devel at ipxe.org
Subject: Re: [PATCH 2/2] Sync VLAN irq operation with trunk irq opertaion.

On 05/03/14 12:44, Wissam Shoukair wrote:
>   	netdev_init ( netdev, &vlan_operations );
> +	/* Nullify irq function if the trunk doesnt support interrupts */
> +	if ( ! netdev_irq_supported( trunk ) ) {
> +		netdev->op->irq = NULL;
> +	}

That will overwrite the .irq field within the static vlan_operations structure, thereby disabling IRQs for all possible VLAN devices, not just this one.

Michael


More information about the ipxe-devel mailing list