[ipxe-devel] Patch tracking

Robin Smidsrød robin at smidsrod.no
Wed Mar 6 16:52:06 UTC 2013


On 06.03.2013 16:38, Michael Brown wrote:
> On 06/03/13 15:10, Robin Smidsrød wrote:
>> I renamed the cmdline binary to "prq" and released 0.0.4. CPAN should
>> pick it up shortly.
> 
> Got it and installed.  Listing pull requests and showing diffs seems to
> work!

Awesome!

> How do I mark a pull request as closed?

Unfortunately I don't know how to do that yet using the API. For now
you'll either need to use the web interface to close the opened PR as
explained here, https://help.github.com/articles/closing-a-pull-request,
or write the following in a commit message to automatically close it:

    fixes #xxx
    fixed #xxx
    close #xxx
    closes #xxx
    closed #xxx

This information gleamed from:

http://stackoverflow.com/questions/1687262/link-to-github-issue-number-with-commit-message

Be aware that using that language in the commit message does reference
the issue number, not the pull request number. I'm not sure if they are
linked directly (one-to-one), but as the "issues" tab is disabled on
ipxe/ipxe I don't think it should make any difference.

I guess the few times when you want to close a pull request without
actually committing it, you'll have to use the web interface.

In the meantime, I'll research some more and see if I can figure out how
to close a PR and adding a comment using the API.

-- Robin




More information about the ipxe-devel mailing list