[ipxe-devel] truncate menu title

Christian Hesse list at eworm.de
Wed May 2 10:02:50 UTC 2012


Christian Hesse <list at eworm.de> on Fri, 2012/04/13 21:58:
> Michael Brown <mbrown at fensystems.co.uk> on Wed, 2012/04/11 23:34:
> > On Wednesday 11 Apr 2012 22:30:48 Christian Hesse wrote:
> > > Christian Hesse <list at eworm.de> on Wed, 2012/04/04 11:37:
> > > > Hello everybody,
> > > > 
> > > > if menu title is longer than 80 characters it is not displayed at all.
> > > > This patch truncates it at MENU_COLS.
> > > 
> > > A lot of stuff has been submitted to git. What about this patch, any
> > > comments? (Hope this is not because I missed the [PATCH]-tag in
> > > subject...)
> > 
> > Not lost; it just takes me some time to work through the patch backlog.
> > In the case of this particular patch, I'd like to find an alternative way
> > to implement it, since this way involves hardcoding knowledge of the UI
> > into the command implementation (which is currently UI-agnostic).  I'd
> > prefer to keep the command implementation as-is, and have the truncation
> > handled entirely within the UI code.
> 
> Agreed. ;)
> 
> So more like this?

Any thoughts about this? I would be happy to rework this again if you still
have objections.
-- 
Best regards,
Chris
                         O< ascii ribbon campaign
                   stop html mail - www.asciiribbon.org



More information about the ipxe-devel mailing list