[ipxe-devel] double null byte in dns_make_name()

[Michael Brown]

On Monday 09 Jan 2012 10:53:44 Christian Hesse wrote:
> Michael Brown <mbrown at fensystems.co.uk> on Sat, 7 Jan 2012 14:07:01 +0000:
> > On Saturday 07 Jan 2012 13:50:01 Christian Hesse wrote:
> > > > Applying your patch causes malformed DNS requests for me.  That
> > > > trailing NUL marks the end of the name being queried.
> > > > 
> > > > Could you send a packet capture showing the "double null" behaviour
> > > > that you describe?
> > > 
> > > I will do anytime next week.
> > > 
> > > Just an idea that came to my mind just right now... Is a dot at the end
> > > of the name handled differently? I had sat the path to
> > > "http://pxe./script".
> > 
> > Yes; that makes a difference, and when I add a trailing dot I can see the
> > double-NUL behaviour that you describe.
> 
> Ah, great. I support the dump is not needed then?

Should now be fixed:

  http://git.ipxe.org/ipxe.git/commitdiff/187cd80

Michael