[ipxe-devel] [gPXE-devel] [PATCH 1/4] [io] Move get_memmap() to the I/O API group

Piotr Jaroszyński p.jaroszynski at gmail.com
Tue Aug 17 00:24:22 UTC 2010


2010/8/17 Geoff Lywood <glywood at vmware.com>:
> I don't want my comments to block the work that you are doing. I'm not against your change: I think it is a definite improvement, I just wanted to throw some ideas around.

I appreciate your comments, in fact moving the b44 to driver arch/i386
sounds like a good option to me, but I would like to get Michael's
opinion on that as he suggested moving get_memmap to the I/O API group
in the first place and already merged the patchset in ipxe :)
Wrt the second option it just seems to be a bigger undertaking which I
think should be covered in a separate patchset.

> If you decide to go with a stub efi_get_memmap(), can you at least fix the b44 driver so that it errors out if memmap.count == 0?

I did include that in the patch.

-- 
Piotr



More information about the ipxe-devel mailing list